Skip to content

Keep rich core Djot on the fast HTML path #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
Aug 21, 2026
Merged

Keep rich core Djot on the fast HTML path #277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 25 additions & 6 deletions src/Parser/BlockParser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,11 +524,28 @@ public function parse(string $input): Document

$lines = $this->splitLines($input);

// First pass: extract reference definitions, footnotes, abbreviations, and heading references
$this->extractReferences($lines);
$this->extractFootnotes($lines);
$this->extractAbbreviations($lines);
$this->extractHeadingReferences($lines);
// Gate document-wide collectors by syntax family. The predicates only
// skip impossible families; false positives merely retain the existing
// authoritative pass.
$hasReferenceDefinitions = preg_match(
'/(?:^|\n)\[[^\]\r\n]+\]:(?:[ \t]+\S*)?[ \t]*(?:\r?\n|$)/',
$input,
) === 1;
$hasFootnotes = str_contains($input, '[^');
$hasAbbreviations = str_contains($input, '*[');
$hasImplicitHeadingReferences = preg_match('/\]\s*\[\]/', $input) === 1;
if ($hasReferenceDefinitions) {
$this->extractReferences($lines);
}
if ($hasFootnotes) {
$this->extractFootnotes($lines);
}
if ($hasAbbreviations) {
$this->extractAbbreviations($lines);
}
if ($hasImplicitHeadingReferences || $this->collectWarnings) {
$this->extractHeadingReferences($lines);
}

// Second pass: parse blocks
$this->parseBlocks($document, $lines, 0);
Expand All @@ -543,7 +560,9 @@ public function parse(string $input): Document
// attributes) and rewrite implicit heading references to the same
// deduped ids the renderer will emit, so `[Heading][]` anchors stay
// in sync with the rendered section id.
$this->rewriteHeadingReferences($document);
if ($hasImplicitHeadingReferences || $this->collectWarnings) {
$this->rewriteHeadingReferences($document);
}

// Validate references and anchor links if warnings are enabled
if ($this->collectWarnings) {
Expand Down
Loading
Loading