Skip to content

New methods added#32

Closed
pankaj-bind wants to merge 5 commits into
pharo-containers:masterfrom
pankaj-bind:new-methods-added
Closed

New methods added#32
pankaj-bind wants to merge 5 commits into
pharo-containers:masterfrom
pankaj-bind:new-methods-added

Conversation

@pankaj-bind

Copy link
Copy Markdown

fix #31
image

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14798591735

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.764%

Totals Coverage Status
Change from base Build 11551680919: 0.0%
Covered Lines: 812
Relevant Lines: 1018

💛 - Coveralls

1 similar comment
@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14798591735

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.764%

Totals Coverage Status
Change from base Build 11551680919: 0.0%
Covered Lines: 812
Relevant Lines: 1018

💛 - Coveralls

@coveralls

coveralls commented May 2, 2025

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 14812414249

Details

  • 60 of 96 (62.5%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 77.062%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Containers-Array2D/CTAlternateArray2D.class.st 60 65 92.31%
src/Containers-Array2D/CTArray2D.class.st 0 31 0.0%
Totals Coverage Status
Change from base Build 11551680919: -2.7%
Covered Lines: 813
Relevant Lines: 1055

💛 - Coveralls

@pankaj-bind

Copy link
Copy Markdown
Author

@jordanmontt all issues have been resolved, now you can merge this PR and CI of edit-distances will become green

@jordanmontt

Copy link
Copy Markdown
Member
Capture d’écran 2025-05-03 à 17 04 24 The methods are still as extensions. Which is weird...

@pankaj-bind

pankaj-bind commented May 3, 2025

Copy link
Copy Markdown
Author

wait for some time, do not merge this PR, I will make an update

@pankaj-bind

Copy link
Copy Markdown
Author

@jordanmontt Now it's ready to go

@jordanmontt

Copy link
Copy Markdown
Member

@Ducasse I would like your review on this one :)

@jordanmontt

Copy link
Copy Markdown
Member

I think is better to close this PR for now. We should think carefully which methods to add while maintaining a minimal API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adding new methods to fix CI

3 participants