Skip to content

fix: include offending values in mapping_section assertion error (#1367) #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangzhengdna-lang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: include offending values in mapping_section assertion error (#1367) #1416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: aNCA
Title: (Pre-)Clinical NCA in a Dynamic Shiny App
Version: 0.1.0.9188
Version: 0.1.0.9189
Authors@R: c(
person("Ercan", "Suekuer", email = "ercan.suekuer@roche.com", role = "aut",
comment = c(ORCID = "0009-0001-1626-1526")),
Expand Down
1 change: 1 addition & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
* CMAX auto-selected in box plots if available (#890)

### Data & Mapping
* Mapping section assertion error now reports the count and offending `mapping_section` values for easier debugging (#1367)
* ADNCA now includes `PKSUM1RS` column storing the general exclusion reason when `PKSUM1F = "Y"` (#1331)
* Upload multiple input files, bound into a single ADNCA dataset (#821)
* Optional mapping of AEFRLT for excretion rate parameters (ERTLST, ERTMAX) (#745)
Expand Down
5 changes: 4 additions & 1 deletion inst/shiny/modules/tab_data/data_mapping.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,10 @@ MAPPING_BY_SECTION <- MAPPING_BY_SECTION[sections_order]
.column_mapping_section <- function(ns, mapping_df) {
section_title <- unique(mapping_df$mapping_section)
if (length(section_title) != 1) {
stop("mapping_df must contain exactly one unique mapping_section value.")
stop(
"mapping_df must contain exactly one unique mapping_section value, but found ",
length(section_title), ": ", paste(section_title, collapse = ", ")
)
}
tags$section(
h5(section_title),
Expand Down
Loading