Skip to content

Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calixteman wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Doc: add nth-child in the list of pseudo classes for option --exclude-pseudoclasses #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2018bb4
Set exclude_pseudoclasses to False by default to have the same behavi…
calixteman Apr 25, 2019
0c92e0e
Set default value for --exclude-pseudoclasse to True
calixteman Apr 25, 2019
c59e71d
Finally don't change the default
calixteman Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ module.
--remove-internal-links PRESERVE_INTERNAL_LINKS
Remove links that start with a '#' like anchors.
--exclude-pseudoclasses
Pseudo classes like p:last-child', p:first-child, etc
Pseudo classes like p:last-child', p:first-child, :nth-child, etc
Copy link
Copy Markdown
Owner

@peterbe peterbe Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this change in __main__.py too? Line ~53.

Copy link
Copy Markdown
Contributor Author

@calixteman calixteman Apr 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already did it.

--preserve-style-tags
Do not delete <style></style> tags from the html
document.
Expand Down
2 changes: 1 addition & 1 deletion premailer/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def main(args):
parser.add_argument(
"--exclude-pseudoclasses",
default=False,
help="Pseudo classes like p:last-child', p:first-child, etc",
help="Pseudo classes like p:last-child', p:first-child, :nth-child, etc",
action="store_true",
dest="exclude_pseudoclasses",
)
Expand Down