Fix #1077 : Solve the bad route selection based on acceptType - #1238
Open
Chauncey-Xxy wants to merge 1 commit into
Open
Fix #1077 : Solve the bad route selection based on acceptType#1238Chauncey-Xxy wants to merge 1 commit into
Chauncey-Xxy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #1077
Because the #1224 request has some bugs, and I deleted the repository during the previous test, so close the previous request and pull the new request:
I am not sure whether it is a bug, because it is tagged as Bug ..?, but I think it conflict with the documentation, so I try to fix it.
In short, we expect the input with empty acceptType will match any possible types as follows:
curl -i -H "Accept: application/json" http://localhost:4567/hello : Hello application json
curl -i -H "Accept: text/html" http://localhost:4567/hello : Go Away!!!
curl http://localhost:4567/hello : Hello application json
Now the first and second are right, but the last command will get output: Go Away!!!
I think it is not reasonable because the empty acceptType should match every possibilities and use the earliest match principle, it should match the first possible acceptType.
So I change the codes to match "/" with the earliest acceptType.
Co-Authored-By: Bugjudger 56737316+bugjudger@users.noreply.github.com