Skip to content

fix(json): modify json.lua to support larger numbers #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtfiedler wants to merge 2 commits into from
Closed

fix(json): modify json.lua to support larger numbers #1053

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0acefd8
fix(json): modify json.lua to support larger numbers
dtfiedler Oct 22, 2024
2c8aa83
fix(json): modify to 20 significant digits and check if integer directly
dtfiedler Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions dev-cli/container/src/json.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,15 @@ end
local function encode_number(val)
-- Check for NaN, -inf and inf
if val ~= val or val <= -math.huge or val >= math.huge then
error("unexpected number value '" .. tostring(val) .. "'")
error("unexpected number value '" .. tostring(val) .. "'")
end
-- Handle integer values separately to avoid floating-point conversion
if math.type(val) == "integer" then
return string.format("%d", val) -- Format as an integer
else
-- Use 20 significant digits for non-integer numbers
return string.format("%.20g", val)
end
return string.format("%.14g", val)
end

local type_func_map = {
Expand Down