Skip to content

PS-8822 [8.0]: Patch-1: Avoid calling validate() in non-debug in rec_offs_*() #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
polchawa-percona wants to merge 1 commit into
base: 8.0
Choose a base branch
from
+4 −4
Open

PS-8822 [8.0]: Patch-1: Avoid calling validate() in non-debug in rec_offs_*() #5922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion storage/innobase/include/rem0wrec.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ void validate_rec_offset(const dict_index_t *index, const ulint *offsets,
n = index->get_field_off_pos(n);
}

validate_rec_offset(index, offsets, n, UT_LOCATION_HERE);
ut_d(validate_rec_offset(index, offsets, n, UT_LOCATION_HERE));
/* Returns nonzero if the extern bit is set in nth field of rec. */
return rec_offs_base(offsets)[1 + n] & REC_OFFS_EXTERNAL;
}
Expand Down
6 changes: 3 additions & 3 deletions storage/innobase/rem/rem0wrec.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ ulint rec_offs_nth_sql_null(const dict_index_t *index, const ulint *offsets,
n = index->get_field_off_pos(n);
}

validate_rec_offset(index, offsets, n, UT_LOCATION_HERE);
ut_d(validate_rec_offset(index, offsets, n, UT_LOCATION_HERE));
return (rec_offs_nth_sql_null_low(offsets, n));
}

Expand All @@ -137,7 +137,7 @@ ulint rec_offs_nth_default(const dict_index_t *index, const ulint *offsets,
n = index->get_field_off_pos(n);
}

validate_rec_offset(index, offsets, n, UT_LOCATION_HERE);
ut_d(validate_rec_offset(index, offsets, n, UT_LOCATION_HERE));
return (rec_offs_nth_default_low(offsets, n));
}

Expand All @@ -147,7 +147,7 @@ ulint rec_offs_nth_size(const dict_index_t *index, const ulint *offsets,
n = index->get_field_off_pos(n);
}

validate_rec_offset(index, offsets, n, UT_LOCATION_HERE);
ut_d(validate_rec_offset(index, offsets, n, UT_LOCATION_HERE));
return (rec_offs_nth_size_low(offsets, n));
}

Expand Down