ENHANCEMENT-3610: Use getNormalizedSdkConfig and avoid mashup and por…#648
Open
vrseraphin wants to merge 1 commit into
Open
ENHANCEMENT-3610: Use getNormalizedSdkConfig and avoid mashup and por…#648vrseraphin wants to merge 1 commit into
vrseraphin wants to merge 1 commit into
Conversation
vrseraphin
force-pushed
the
feat/serav/enh-3610
branch
from
33f54ba to
326eae2
Compare
Contributor
|
Shouldn't we move to getNormalizedSdkConfig in MainScreen and FullPortal components? |
Contributor
Author
Didn't find that the portal sample code was referencing either "mashup" or "portal" authConfig variants...so hadn't bothered with trying to move these, but we could. |
vrseraphin
force-pushed
the
feat/serav/enh-3610
branch
2 times, most recently
from
7df9702 to
a97580e
Compare
…tal prefixed attribute name within code.
vrseraphin
force-pushed
the
feat/serav/enh-3610
branch
from
a97580e to
59e6d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tal prefixed attribute name within code.