fix(db-postgres): keep generated down migrations idempotent#17490
Open
deepshekhardas wants to merge 1 commit into
Open
fix(db-postgres): keep generated down migrations idempotent#17490deepshekhardas wants to merge 1 commit into
deepshekhardas wants to merge 1 commit into
Conversation
Generated migrations sequence the dependent drops drizzle-kit emits, but Postgres also drops foreign keys when its referenced table is dropped with CASCADE. Subsequent ALTER TABLE … DROP CONSTRAINT / DROP INDEX statements in the same script then fail because the objects are already gone. Rewrite those drops to use IF EXISTS in db-postgres and db-vercel-postgres before the SQL is written to the migration file. Fixes payloadcms#14800.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased on latest main with conflict resolution.\n\nConflict resolved:\n- packages/drizzle/src/exports/postgres.ts: kept both PR's makePostgresDropsIdempotent export and upstream's migratePostgresLocalizeStatus export