fix(ui): add missing React keys in folder list views#17462
Open
traczoskar wants to merge 1 commit into
Open
Conversation
traczoskar
requested review from
AlessioGr,
JarrodMFlesch and
jacobsfletch
as code owners
July 23, 2026 13:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With folders enabled, published
@payloadcms/ui(built with React Compiler) triggers React console warnings:Folder UI renders
ColoredFolderIconnext to a label (and list-view tab buttons) as sibling children. In source TSX this is valid as normal JSX children. Afterbuild:reactcompiler, those siblings are emitted as an array of elements without keys, for example:React then warns about missing keys (often attributed to a minified parent from
CollectionFolderView).This PR adds stable
keyprops in the source so they survive the React Compiler build:key="folder-icon"onColoredFolderIconin folder breadcrumbs / table / move drawerkey="all-tab" | "folders-tab" | "trash-tab"onDefaultListViewTabsbuttonsReproduction
@payloadcms/uipackage (not monorepo source-aliaspnpm dev, which points at TSX and does not surface this warning).Alternatively, after
pnpm turbo build --filter="@payloadcms/ui...", inspect compiled output:Before this fix the pattern has no key; after rebuild it should include
key: "folder-icon".Notes
3.x(folder UI). Onmainthis area is being replaced by hierarchy.