fix: pass id to delete access control on trash attempts in updateByID#17454
Open
mariovalney wants to merge 1 commit into
Open
fix: pass id to delete access control on trash attempts in updateByID#17454mariovalney wants to merge 1 commit into
mariovalney wants to merge 1 commit into
Conversation
The delete access control callback did not receive the document id when checking permissions for a soft-delete (trash) attempt inside updateByID, making it impossible to rely on id in access functions and forcing developers to inspect data.deletedAt instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The delete access control callback did not receive the document id when checking permissions for a soft-delete (trash) attempt inside updateByID, making it impossible to rely on id in access functions and forcing developers to inspect data.deletedAt instead.
Fixes #17452