fix: restore version fails validation on relationship filterOptions fields#17446
Open
r1tsuu wants to merge 1 commit into
Open
fix: restore version fails validation on relationship filterOptions fields#17446r1tsuu wants to merge 1 commit into
r1tsuu wants to merge 1 commit into
Conversation
…ields
Restoring a version via the REST API threw a spurious `ValidationError`
("This field has the following invalid selections") for any relationship
field that defines `filterOptions`.
`restoreVersionOperation` derives a validation-locale request with
`Object.assign(Object.create(req), req, ...)`. Since `req` is the incoming
web `Request`, its `headers`/`url` are getters backed by private class
fields. The derived object leaves those getters on the prototype, so when
`validateFilterOptions` -> `createLocalReq` reads `req.headers`, the getter
runs with the wrong receiver and throws "Cannot read private member
#request from an object whose class did not declare it". The throw is
swallowed by `validateFilterOptions`, which then reports every selection as
invalid, producing an HTTP 400.
Copy the resolved `headers`/`url` onto the derived request as own data
properties so they no longer delegate to the private-field getters.
Adds a REST-based regression test that restores a version of a draft with a
`filterOptions` relationship field (fails with 400 before the fix).
r1tsuu
changed the title
Contributor
|
Pull Request titles must follow the Conventional Commits specification and have valid scopes. No release type found in pull request title " fix: restore version fails validation on relationship filterOptions fields". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/ Available types:
|
Contributor
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a version via the REST API threw a
ValidationError("This field has the following invalid selections") for any relationship field that definesfilterOptions.Adds a REST-based regression test that restores a version of a draft with a
filterOptionsrelationship field (fails with 400 before the fix).