chore: add e2e-pr-assets project skill#17391
Closed
JarrodMFlesch wants to merge 13 commits into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
If we could upload assets and have them render inline so you don't have to do the github auth dance that would be amazing. I just could not get it to work, it would render the links and never show the inline preview for the vids. |
Contributor
Author
|
Closing in favor of payloadcms/skills#6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a project skill for capturing and attaching before/after admin UI evidence from e2e runs directly in pull requests.
Use
e2e-pr-assetswhen a PR needs visual proof of behavior changes, either as inline H.264 video links or screenshots, with a consistentBefore/Afterblock in the PR body.It’s intended for validating UX-impacting fixes and features where reviewers benefit from seeing the interaction outcome instead of only reading test/code changes.
Security defaults for the helper flow use temporary paths by default:
/tmp/github-upload-profileE2E_GITHUB_AUTO_REMOVE_PROFILE=0to keep it)/tmp/payload-e2e-before|after.{mp4,webm,png}are removed aftere2e-attach-prby default (E2E_MEDIA_AUTO_CLEANUP=0to keep them)Why upload via GitHub UI (instead of pasting URLs)
GitHub only renders inline video playback reliably when the assets are uploaded through the PR/issue attachment flow (the same
user-attachmentsflow this skill automates). In practice, manually pasted URLs do not consistently hydrate as embedded players in the PR UI, so the skill uploads through the UI path first and then inserts those generated attachment URLs into the PR body.Use case
I used this skill to generate before/after assets on these PRs: