Remove sender sigs from receiver psbt_to_sign#1560
Merged
Conversation
Collaborator
Coverage Report for CI Build 25944304013Coverage increased (+0.004%) to 85.297%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
approved these changes
May 15, 2026
Collaborator
spacebear21
left a comment
spacebear21
left a comment
There was a problem hiding this comment.
utACK, clean and reasonable refactor
arminsabouri
approved these changes
May 16, 2026
| tracing::trace!("Clearing sender input {i}"); | ||
| psbt.inputs[i].final_script_sig = None; | ||
| psbt.inputs[i].final_script_witness = None; | ||
| psbt.inputs[i].tap_key_sig = None; |
Collaborator
There was a problem hiding this comment.
Odd that we remove keyspend sigs and not script or any other partial sig. Which should not be present either way (only final_script_sig or final_script_witness)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
psbt_to_signhelper function in theProvisionalProposaltypestate in v1 and v2 returns the provisional proposal without removing the outdated sender signature elements. Since the purpose of this helper function is to allow the caller to extract the PSBT for the payjoin proposal tx so that it can be signed outside of the state machine flow it makes sense to return a PSBT that has already stripped the outdated sender signature(s) rather than forcing the caller to do this themselves.Misc
This was suggested to be a separate PR that could probably get merged faster here.
Please confirm the following before requesting review:
AI
in the body of this PR.