Multi tab compatibility. - #32
Conversation
We didn't notice this while fixing the previous one. There's some duplication here but I guess it's OK for now.
Resets for the timepicker too. Also deletes time obj from storage when leaving so that yestrday's time object that might be higher than today's current won't be displayed.
Modified lint rules to allow console.error(). Also fixed few lint warnings/errors and remvoed an unncessary blank file.
|
Now, different tabs are completely independent right? |
|
yeah, it's something that people have varying opinions. I think we'll just hold this and plan to release the current one. It should probably be something that should be customisable which would be easier to implement by adding a normal page(not popup) for extension. |
|
If we want to release it, then I guess we could leave this feature out. I think it's necessary to have the alertwords saved. What do you think? |
|
I mean the default that gets filled automatically. I think that should be saved and shown on links that being used for the first time too. |
We do save them now. |
I didn't get this |
|
The URL there, it is specific right. I am thinking, if I set alert words for a meeting and join another after that, then the alert words from the previous meeting aren't shown by default. Is this the case? |
|
yes, with the changes in the last commit. I didn't complete implementing it(maybe I did, but didn't test) thinking we'll not do this for the release. |
see the last commit, everything else is same as #31
This is incomplete as we have a decision to make whether to make all tabs have the same alert words or the same threshold or let them vary.