Skip to content

Multi tab compatibility. - #32

Open
chdinesh1089 wants to merge 4 commits into
masterfrom
multi_tab
Open

Multi tab compatibility.#32
chdinesh1089 wants to merge 4 commits into
masterfrom
multi_tab

Conversation

@chdinesh1089

Copy link
Copy Markdown
Collaborator

see the last commit, everything else is same as #31

This is incomplete as we have a decision to make whether to make all tabs have the same alert words or the same threshold or let them vary.

We didn't notice this while fixing the previous one.
There's some duplication here but I guess it's OK for now.
Resets for the timepicker too. Also deletes time obj from
storage when leaving so that yestrday's time object that might be
higher than today's current won't be displayed.
Modified lint rules to allow console.error(). Also fixed
few lint warnings/errors and remvoed an unncessary blank file.
@Arun-42

Arun-42 commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

Now, different tabs are completely independent right?
I think we should make the leave threshold and alert words global (not URL specific) in storage. Mainly because if I set alert words and threshold for one class then I want it to show the same thing when attending the next class too (different URLs).

@chdinesh1089

Copy link
Copy Markdown
Collaborator Author

yeah, it's something that people have varying opinions. I think we'll just hold this and plan to release the current one. It should probably be something that should be customisable which would be easier to implement by adding a normal page(not popup) for extension.

@Arun-42

Arun-42 commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

If we want to release it, then I guess we could leave this feature out. I think it's necessary to have the alertwords saved. What do you think?

@Arun-42

Arun-42 commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

I mean the default that gets filled automatically. I think that should be saved and shown on links that being used for the first time too.

@chdinesh1089

Copy link
Copy Markdown
Collaborator Author

I think it's necessary to have the alertwords saved.

We do save them now.

@chdinesh1089

Copy link
Copy Markdown
Collaborator Author

I mean the default that gets filled automatically. I think that should be saved and shown on links that being used for the first time too.

I didn't get this

@Arun-42

Arun-42 commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

The URL there, it is specific right. I am thinking, if I set alert words for a meeting and join another after that, then the alert words from the previous meeting aren't shown by default. Is this the case?

@chdinesh1089

chdinesh1089 commented Sep 27, 2020

Copy link
Copy Markdown
Collaborator Author

yes, with the changes in the last commit. I didn't complete implementing it(maybe I did, but didn't test) thinking we'll not do this for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants