Fix workspace member node_modules detection

[jackjennings]

I've run into an issue with the JavaScript backend: when a workspace member has its own node_modules (e.g. in the case that there is a version conflict between the member's package version and the root packages) the member's node_modules are present in the Pants sandbox.

The node_modules_directories method in nodejs_project_environment.py was designed to yield workspace member node_modules paths, but the condition if self.package was always the resolve root (because _run_tool_with_resolve always calls install_node_packages_for_address with the root package's address).

Code written with Claude using TDD methodology.

[tobni]

Tricky!

But LGTM. When CI is happy I will approve.

[jackjennings]

Hey @tobni — I'm running into some issues with running pants locally that I haven't been able to resolve (posted about them in the #development slack channel). If this seems valuable to land, feel free to take over the pull request -- otherwise my entire team just got laid off yesterday so our need to patch this has suddenly become less critical.

[sureshjoshi]

Thanks for the contribution. We've just branched for 2.32.x, so merging this pull request now will come out in 2.33.x, please move the release notes updates to docs/notes/2.33.x.md if that's appropriate.

[jackjennings]

@sureshjoshi please see my comment above; if there's value here I'd like to hand this off to the team to land. Our company has been effectively dissolved so I personally don't have immediate need / ability to make the required changes.