-
-
Notifications
You must be signed in to change notification settings - Fork 702
restore coveralls.io test coverage reporting #22700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
223b775
891b9a7
29d8a65
71d9324
5fd08a8
afa30c7
b97d20b
d70ebbb
5fc7762
21515dc
2b4669d
563b0dc
6f2b0d8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -690,6 +690,29 @@ jobs: | |
| for i in ${change_labels}; do | ||
| echo "${i}=true" | tee -a $GITHUB_OUTPUT | ||
| done | ||
| coveralls_done: | ||
| if: (always()) && (needs.classify_changes.outputs.no_code != 'true') | ||
| name: Coveralls Done | ||
| needs: | ||
| - test_python_linux_x86_64_0 | ||
| - test_python_linux_x86_64_1 | ||
| - test_python_linux_x86_64_2 | ||
| - test_python_linux_x86_64_3 | ||
| - test_python_linux_x86_64_4 | ||
| - test_python_linux_x86_64_5 | ||
| - test_python_linux_x86_64_6 | ||
| - test_python_linux_x86_64_7 | ||
| - test_python_linux_x86_64_8 | ||
| - test_python_linux_x86_64_9 | ||
| - test_python_linux_arm64 | ||
| - test_python_macos13_x86_64 | ||
| - classify_changes | ||
| runs-on: | ||
| - ubuntu-22.04 | ||
| steps: | ||
| - uses: coverallsapp/github-action@v2 | ||
| with: | ||
| parallel-finished: true | ||
| lint_python: | ||
| if: (github.repository_owner == 'pantsbuild') && (needs.classify_changes.outputs.no_code != 'true') | ||
| name: Lint Python and Shell | ||
|
|
@@ -793,6 +816,7 @@ jobs: | |
| - build_wheels_macos14_arm64 | ||
| - check_release_notes | ||
| - classify_changes | ||
| - coveralls_done | ||
| - lint_python | ||
| - test_python_linux_arm64 | ||
| - test_python_linux_x86_64_0 | ||
|
|
@@ -873,6 +897,16 @@ jobs: | |
| name: logs-python-test-Linux-ARM64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confirming: This means coveralls can't break a build, right?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not quite, that one is to satisfy the GitHub Action rules so that we upload coverage even if one of the test fails so we can see what code was executed when the test failed. I added |
||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_arm64 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_0: | ||
| env: | ||
|
|
@@ -974,6 +1008,16 @@ jobs: | |
| name: logs-python-test-0_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_0/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_1: | ||
| env: | ||
|
|
@@ -1075,6 +1119,16 @@ jobs: | |
| name: logs-python-test-1_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_1/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_2: | ||
| env: | ||
|
|
@@ -1176,6 +1230,16 @@ jobs: | |
| name: logs-python-test-2_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_2/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_3: | ||
| env: | ||
|
|
@@ -1277,6 +1341,16 @@ jobs: | |
| name: logs-python-test-3_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_3/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_4: | ||
| env: | ||
|
|
@@ -1378,6 +1452,16 @@ jobs: | |
| name: logs-python-test-4_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_4/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_5: | ||
| env: | ||
|
|
@@ -1479,6 +1563,16 @@ jobs: | |
| name: logs-python-test-5_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_5/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_6: | ||
| env: | ||
|
|
@@ -1580,6 +1674,16 @@ jobs: | |
| name: logs-python-test-6_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_6/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_7: | ||
| env: | ||
|
|
@@ -1681,6 +1785,16 @@ jobs: | |
| name: logs-python-test-7_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_7/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_8: | ||
| env: | ||
|
|
@@ -1782,6 +1896,16 @@ jobs: | |
| name: logs-python-test-8_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_8/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_linux_x86_64_9: | ||
| env: | ||
|
|
@@ -1883,6 +2007,16 @@ jobs: | |
| name: logs-python-test-9_10-Linux-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_linux_x86_64_9/10 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| test_python_macos13_x86_64: | ||
| env: | ||
|
|
@@ -1953,6 +2087,16 @@ jobs: | |
| name: logs-python-test-macOS13-x86_64 | ||
| overwrite: 'true' | ||
| path: .pants.d/workdir/*.log | ||
| - continue-on-error: true | ||
| if: always() | ||
| name: Report coverage to coveralls.io | ||
| uses: coverallsapp/github-action@v2 | ||
| with: | ||
| allow-empty: true | ||
| file: dist/coverage/python/coverage.xml | ||
| flag-name: test_python_macos13_x86_64 | ||
| format: cobertura | ||
| parallel: true | ||
| timeout-minutes: 90 | ||
| name: Pull Request CI | ||
| 'on': | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason 22?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, it is what our generator script spit out.