migrate task_executor crate to Rust 2024 Edition#22688
Merged
Conversation
tdyas
added
category:internal
benjyw
reviewed
Sep 22, 2025
tdyas
force-pushed
the
rust/2024/task_executor
branch
from
ddb08b1 to
7babb14
Compare
benjyw
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the
task_executorcrate to Rust 2024 Edition.The signature of
task_executor::Executor::spawn_blockingwas causing errors due to changes in the 2024 Edition around how lifetimes are captured for return-positionimpl Traits. Sincespawn_blockingcalled the existingnative_spawn_blockingmethod in its implementation, it was easier to just migrate all callers tonative_spawn_blockingwhich didn't have issues due to the edition change.Finally,
spawn_blockingcould then be replaced entirely bynative_spawn_blocking(which is renamed tospawn_blocking).The main resulting change is that callers now have to account for the
JoinErrorwhenawait'ing theJoinHandlereturned bynative_spawn_blocking(e.g., with amap_err(...)instead of passing a second argument tospawn_blockingto do an impliedmap_err.