Conversation
Owner
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
📊 Coverage Report
Coverage Thresholds
Coverage reports generated by CI workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for human review — do NOT auto-merge
Autopilot integration PR for the fleet-overview-filters feature. Delivered across
develop; all phase gates passed with green CI. A human decides whether to merge intomain.What shipped
The Remediation Fleet Overview now defaults to the rows operators can act on, via two independent, combinable client-side toggle filters — with a distinct empty state when the filters hide everything.
FleetOverview.tsx:onlyWithPrs(openPrCount > 0) +onlyEligible(eligible === true) boolean states, both default ON, AND-combined into a derivedfilteredFleetover the already-fetcheduseFleetRemediation()rows. No backend/API change.Switch+Labeltoggles above the table (mirrorsPolicyEditor/RepositoryFilterSettings); toggling either widens the view.remediation:fleet.filters.noMatch) with a "Show all repositories" escape + always-visible toggles — separate from the existing zero-reposremediation:fleet.emptystate.remediation:fleet.filters.*keys (onlyWithPrs,onlyEligible,noMatch,clear,groupLabel);frontend/src/i18n/types.tsregenerated in sync.role="group"+aria-labelon the filter cluster,role="status" aria-live="polite"on the no-match state.Phase gate summary
9ea5c91(#75)The plan was originally 2 phases (filters+EN, then translate); Ampel CI's i18n
missinggate fails any PR with en-only keys, so the 27-locale translation was carried in phase 0's PR and the plan was collapsed to one phase to match what shipped.Verification (on
develop)make test-frontend— 924 passed, 6 skipped (61 files); 13FleetOverviewspecs (each filter proven independently, toggle round-trip, single-toggle escape from empty, revealed-row preview).make lint-frontend·make format-check·type-check— clean.missingclean · coverage 100% ·types.tsin sync · all 27 locales carry the 5 keys.Review signals
🤖 Automated autopilot feature. Ready for human review; do NOT auto-merge.