CI: Add missing rustup components#26
CI: Add missing rustup components#26fmease wants to merge 1 commit intopacman-repo-builder:masterfrom
Conversation
7c8377a to
9389b36
Compare
9389b36 to
4b2fd81
Compare
fmease
left a comment
There was a problem hiding this comment.
Okay, so I've iterated on this in my fork (fmease-extra#1) and it seems to work: https://github.com/fmease-extra/KSXGitHub__arch-pkg-text/actions/runs/16654576277/job/47136123275
| ${{ github.job }}-${{ runner.os }}-${{ hashFiles('rust-toolchain.toml') }}- | ||
|
|
||
| - name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable |
There was a problem hiding this comment.
I've removed the dtolnay/rust-toolchain action because it doesn't work well or at all with the rust-toolchain / rust-toolchain.toml file. See dtolnay/rust-toolchain#159.
I still don't know why it used to work a few months ago in your project. Maybe rustup changed its behavior in a recent version, that's my only explanation.
At least on ubuntu-latest which this workflow uses, rustup comes preinstalled, so we can just use it directly to install the toolchain.
There was a problem hiding this comment.
I also tried to just specify the components (https://github.com/dtolnay/rust-toolchain?tab=readme-ov-file#inputs):
- name: Install Rust toolchain
- name: Install Rust toolchain
uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt, clippybut that didn't seem to get picked up by rustup, so I scraped it.
There was a problem hiding this comment.
I have been aware of the failure of dtolnay/rust-toolchain for a while. So I dropped it in favor of a simpler solution: #26 (review)
There was a problem hiding this comment.
I planned to address this PR in the weekends by pushing the real fix, but since I don't want to see you pulling your hair out. This is the real fix: KSXGitHub/parallel-disk-usage#278
|
I see, thanks for the quick reply! Feel free to close this PR then. I don't quite see the need to manually install |
The |
|
I meant the version of |
|
I see. Well I just copied my workflow files around without any deep thought to it. Maybe remove the action entirely still work after all? I will test it this weekends. |
The preinstalled Commit: e68c5b1 |
This attempts to fix the CI failure experienced in PR #25: https://github.com/pacman-repo-builder/arch-pkg-text/actions/runs/16651411652/job/47125370150.
I don't know what changed in the last few months, the latest commit on the master branch 9454e83 from March 22 is green.
I might be looking at the wrong thing but it seems like dtolnay/rust-toolchain installs Rust toolchains with the minimal profile: https://github.com/dtolnay/rust-toolchain/blob/4305c38b25d97ef35a8ad1f985ccf2d2242004f2/action.yml#L90. That profile doesn't contain the components rustfmt and clippy. It's odd though because that seems to have been the case for several years, so I don't know why CI used to work just fine a few months ago.
Edit: Not sure if this will fix it, I'll try to test it in my fork.Done.