Skip to content

dropshot-api-manager 0.7.1 #1129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
david-crespo merged 6 commits into from
Apr 28, 2026
Merged

dropshot-api-manager 0.7.1 #1129

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9e12e2
dropshot-api-manager 0.7.1
david-crespo Apr 27, 2026
c21e624
whoops, also have to bump progenitor
david-crespo Apr 27, 2026
1ecba01
run all tests in CI
david-crespo Apr 27, 2026
4d06cd3
use actual PR tip for CI
david-crespo Apr 28, 2026
2805680
missing with:
david-crespo Apr 28, 2026
a4e7e68
build-and-test job needs full history for gitstub test
david-crespo Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
# see https://github.com/oxidecomputer/omicron/issues/4461
Copy link
Copy Markdown
Contributor

@jmpesp jmpesp Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need the with: here

Copy link
Copy Markdown
Contributor Author

@david-crespo david-crespo Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what I get for doing it by hand

Copy link
Copy Markdown
Contributor

@jmpesp jmpesp Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this needs to be under the build-and-test job :)

# (by default the action picks a merge commit with the target branch
# rather than the actual PR tip)
ref: ${{ github.event.pull_request.head.sha }}
# `test_apis_up_to_date` needs a full history for the gitstubs
fetch-depth: 0
- name: Report rustfmt version
run: cargo fmt -- --version
- name: Check style
Expand Down Expand Up @@ -50,6 +57,8 @@ jobs:
run: cargo build -p propolis-mock-server --verbose
- name: Test Libraries
run: cargo test --lib --verbose
- name: Test everything
run: cargo test --locked
# Build and test propolis-the-library on its own; `cargo test --lib` as used
Copy link
Copy Markdown
Contributor Author

@david-crespo david-crespo Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is copied from #1128

# above builds the entire workspace, meaning propolis-server default features
# are used to build and run propolis-lib tests. Instead, this check uses
Expand Down
Loading
Loading