Skip to content

Fix race condition in JwtDecoder caching with computeIfAbsent #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
buckett merged 3 commits into from
Jan 2, 2026
Merged

Fix race condition in JwtDecoder caching with computeIfAbsent #57

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fce7324
Initial plan
Copilot Jan 2, 2026
af9f3ed
Fix race condition using computeIfAbsent for atomic JwtDecoder creation
Copilot Jan 2, 2026
a094915
Fix grammar in TODO comment (it's -> its)
Copilot Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions ...lti13/security/oauth2/client/lti/authentication/OidcLaunchFlowAuthenticationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,14 @@ private JwtDecoder getJwtDecoder(ClientRegistration clientRegistration) {
);
throw new OAuth2AuthenticationException(oauth2Error, oauth2Error.toString());
}
JwtDecoder jwtDecoder = this.jwtDecoders.get(jwkSetUri);
if (jwtDecoder == null) {
// TODO This should look at the Cache-Control header so to expire old jwtDecoders.
// Canvas looks to rotate it's keys monthly.
NimbusJwtDecoder.JwkSetUriJwtDecoderBuilder decoderBuilder = NimbusJwtDecoder.withJwkSetUri(jwkSetUri).jwsAlgorithm(SignatureAlgorithm.from(JwsAlgorithms.RS256));
// TODO This should look at the Cache-Control header so to expire old jwtDecoders.
// Canvas looks to rotate its keys monthly.
return this.jwtDecoders.computeIfAbsent(jwkSetUri, uri -> {
NimbusJwtDecoder.JwkSetUriJwtDecoderBuilder decoderBuilder = NimbusJwtDecoder.withJwkSetUri(uri).jwsAlgorithm(SignatureAlgorithm.from(JwsAlgorithms.RS256));
if (restOperations != null) {
decoderBuilder.restOperations(restOperations);
}
jwtDecoder = decoderBuilder.build();
this.jwtDecoders.put(jwkSetUri, jwtDecoder);
}
return jwtDecoder;
return decoderBuilder.build();
});
}
}