Skip to content

[full-ci] Upstream small CERNbox fixes#6148

Merged
kulmann merged 3 commits intomasterfrom
small-cern-fixes
Dec 14, 2021
Merged

[full-ci] Upstream small CERNbox fixes#6148
kulmann merged 3 commits intomasterfrom
small-cern-fixes

Conversation

@pascalwengerter
Copy link
Copy Markdown
Contributor

Description

Taking over and finalizing #6088

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

diocas and others added 3 commits December 14, 2021 10:50
* Hide hidden files by default

* Make default title configurable
This title appears before the config title is loaded.

* Optional sourcemaps

* Change login message

* Feedback while loading the app
Show simple spinner (similar to ocSpiner) if it takes too long to load (> 1s);
Show error message when failed to load.

* Apps fixes
Allow img instead of icon
Ensure canBeDefault is honored

* Update tests for app img display
If there's an image, it takes precedence over icon (which always has a default)

* Changelog
@sonarqubecloud
Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

21.1% 21.1% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter marked this pull request as ready for review December 14, 2021 13:50
Copy link
Copy Markdown
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kulmann kulmann merged commit f77752d into master Dec 14, 2021
@delete-merged-branch delete-merged-branch Bot deleted the small-cern-fixes branch December 14, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants