Skip to content

fix: [OCISDEV-868] search for username if group attribute is memberUid - #12814

Open
jvillafanez wants to merge 3 commits into
owncloud:masterfrom
jvillafanez:ldap_group_memberuid
Open

fix: [OCISDEV-868] search for username if group attribute is memberUid#12814
jvillafanez wants to merge 3 commits into
owncloud:masterfrom
jvillafanez:ldap_group_memberuid

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

Description

Group membership assumed LDAP always used either "member" or "uniqueMember" attributes (whose values are DNs), so errors happens when "memberUid" is used.

owncloud/reva#719 might be required because it fixes a related bug.

Related Issue

  • Fixes <issue_link>

Motivation and Context

memberUid can be used as a valid group membership attribute.

How Has This Been Tested?

Manually tested with posixGroups

Screenshots (if appropriate):

Screenshot from 2026-08-18 11-20-37

Side note: the web UI shows the "cn" or displayname of the user, not the "uid"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@jvillafanez jvillafanez self-assigned this Aug 18, 2026
@jvillafanez
jvillafanez requested a review from a team as a code owner August 18, 2026 09:35
@update-docs

update-docs Bot commented Aug 18, 2026

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kw-security

kw-security commented Aug 18, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@jvillafanez
jvillafanez force-pushed the ldap_group_memberuid branch from 4166d0a to 2b88d44 Compare August 18, 2026 11:58
Comment thread services/graph/pkg/identity/ldap.go
Comment thread services/graph/pkg/identity/ldap.go Outdated
Comment thread services/graph/pkg/identity/ldap.go Outdated
Comment thread services/graph/pkg/identity/ldap.go
@jvillafanez
jvillafanez force-pushed the ldap_group_memberuid branch from 1cb47f5 to 22a032b Compare August 24, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants