fix(ttlv): parse DateTime hex values with base 16 instead of base 10#96
Open
fix(ttlv): parse DateTime hex values with base 16 instead of base 10#96
Conversation
The DateTime JSON decoder used strconv.ParseUint with base 10 when parsing 0x-prefixed values, causing hex digits (a-f) to fail parsing.
There was a problem hiding this comment.
Pull request overview
Fixes JSON DateTime decoding for 0x-prefixed epoch values by parsing the numeric portion as hexadecimal (base 16), and adds a regression test to ensure hex-encoded DateTime values decode correctly.
Changes:
- Parse
0x-prefixedDateTimevalues withstrconv.ParseUint(..., 16, 64)instead of base 10. - Add a decoding test covering hex-encoded
DateTimevalues.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ttlv/encoding_json.go |
Corrects base used when parsing 0x-prefixed DateTime values in the JSON reader. |
ttlv/encoding_json_test.go |
Adds a regression test validating hex DateTime decoding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strconv.ParseUintbase parameter inDateTimeJSON decoder:0x-prefixed values were parsed with base 10 instead of base 16, causing any value containing hex digits (a-f) to fail