Conversation
add ReadHeaderTimeout
2c11a35 to
7b272c5
Compare
|
Hi @zhangyongding thanks for this. HTTP client is definitely a good improvement. Maybe a cleaner approach would be to hide transport specific implementation behind an interface that would be used the the |
|
I think your idea is great. |
|
I'm currently working on making the client an interface to allow having specific roundtriper (in your case an http one). |
|
How is the progress now? |
|
#80 added the possibility to precise a custom dialer that will be called. Would that be okay for you to define an http dialer using this interface ? Or is there missing pieces ? |
|
Can you provide a verified example? |
|
There is one here : https://github.com/ovh/kmip-go/blob/main/kmipclient/dialer_cluster_test.go#L17 |
|
https://github.com/ovh/kmip-go/blob/main/kmipclient/dialer_cluster_test.go#L17 Here are all examples using TCP, with no examples using HTTP |
Complete this issue: Add HTTP support to kmip client