Skip to content

Add Module.prototype.load for new Module() instances #29256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 15 commits into
base: main
Choose a base branch
from

test: exercise this.path reset with mismatched ctor id vs load path

ee3ae67
Select commit
Loading
Failed to load commit list.
Open

Add Module.prototype.load for new Module() instances #29256

test: exercise this.path reset with mismatched ctor id vs load path
ee3ae67
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 13, 2026 in 25m 30s

Code review found 2 potential issues

Found 4 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/regression/issue/29253.test.ts:24-43 Missing .name assertion for modulePrototypeLoad fix

Annotations

Check warning on line 43 in test/regression/issue/29253.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Missing .name assertion for modulePrototypeLoad fix 

The test at `test/regression/issue/29253.test.ts` (lines 24-43) checks `typeof m.load === 'function'` and `typeof Module.prototype.load === 'function'` but never asserts `m.load.name === 'load'` or `Module.prototype.load.name === 'load'`. The `$overriddenName = "load"` annotation added in commit 9a99fd35 is the only mechanism keeping `.name` correct, but it is completely unguarded by tests — removing it would leave all 5 tests green while `.name` silently regresses to `'modulePrototypeLoad'`.
View more details on Claude