Skip to content

test: update process.versions mimalloc SHA for dev3 bump

d811dec
Select commit
Loading
Failed to load commit list.
Merged

deps: bump mimalloc to dev3 (bun-dev3-v2) #29251

test: update process.versions mimalloc SHA for dev3 bump
d811dec
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 13, 2026 in 10m 56s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/js/bun/jsc/heapStats-mimalloc.test.ts:48-64 Test never compares before vs after heaps count

Annotations

Check warning on line 64 in test/js/bun/jsc/heapStats-mimalloc.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Test never compares before vs after heaps count

The test "dump reflects new heaps and allocations" records a baseline heap count in `before` but never uses it — the assertion is `expect(after.length).toBeGreaterThanOrEqual(1)` instead of `toBeGreaterThanOrEqual(before)`, and `void before` on line 63 explicitly discards the variable. The test name and inline comment both claim a before/after comparison is performed, but the check only verifies the dump still has at least one heap, so a regression where allocations cause heaps to shrink would g