Skip to content

build: WebKit → preview-pr-181-ebf11e28 #29250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jarred-Sumner wants to merge 4 commits into from

build: WebKit → preview-pr-181-ebf11e28 (fix pthread_once on Windows)

7d5ca23
Select commit
Loading
Failed to load commit list.
Closed

build: WebKit → preview-pr-181-ebf11e28 #29250

build: WebKit → preview-pr-181-ebf11e28 (fix pthread_once on Windows)
7d5ca23
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 13, 2026 in 6m 33s

Code review found 5 potential issues

Found 5 candidates, confirmed 5. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit scripts/build/deps/webkit.ts:6 Build diagnostic tag slice(0,10) loses all uniqueness with preview-style version strings

Annotations

Check warning on line 6 in scripts/build/deps/webkit.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Build diagnostic tag slice(0,10) loses all uniqueness with preview-style version strings 

The build diagnostic in config.ts uses cfg.webkitVersion.slice(0, 10) to emit a feature tag, but for the new preview-format version string "preview-pr-181-ebf11e28" this always produces "preview-pr" — identical for every preview PR build regardless of PR number or commit hash. The unique portion (PR number + 8-char hash) only starts at position 12+, so the 'forgot to revert my WebKit test branch' warning is now useless for preview builds; consider using the full version string or slicing from th
View more details on Claude