build: WebKit → preview-pr-181-ebf11e28 #29250
+1
−1
Closed
Claude / Claude Code Review
completed
Apr 13, 2026 in 6m 18s
Code review found 1 important issue
Found 5 candidates, confirmed 3. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 0 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | scripts/build/deps/webkit.ts:6 |
WEBKIT_VERSION preview tag breaks sync-webkit-source.ts (checkout failure + broken early-exit) |
Annotations
Check failure on line 6 in scripts/build/deps/webkit.ts
claude / Claude Code Review
WEBKIT_VERSION preview tag breaks sync-webkit-source.ts (checkout failure + broken early-exit)
Changing WEBKIT_VERSION to a preview tag string breaks `scripts/sync-webkit-source.ts` in two ways: (1) the `git checkout` on line 24 uses the tag directly, but the actual ref in oven-sh/WebKit is `autobuild-preview-pr-181-68e2ebfa` — `prebuiltUrl()` adds the `autobuild-` prefix for downloads but sync-webkit-source.ts has no such normalization, causing a hard `pathspec did not match` failure; (2) the already-synced early-exit on line 17 compares `git rev-parse HEAD` (a 40-char SHA) to the new ta
Loading