build: WebKit → preview-pr-181-ebf11e28 #29250
+1
−1
Closed
Claude / Claude Code Review
completed
Apr 13, 2026 in 9m 26s
Code review found 2 potential issues
Found 4 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | scripts/build/deps/webkit.ts:6-7 |
prebuiltDestDir slice(0,16) causes cache collisions for preview-style version strings |
| 🟡 Nit | scripts/build/deps/webkit.ts:3-6 |
Stale comment: WEBKIT_VERSION is a preview tag, not a commit hash |
Annotations
Check warning on line 7 in scripts/build/deps/webkit.ts
claude / Claude Code Review
prebuiltDestDir slice(0,16) causes cache collisions for preview-style version strings
The `prebuiltDestDir()` function uses `cfg.webkitVersion.slice(0, 16)` to build the cache directory name, but for the new preview-style version strings like `"preview-pr-181-e38dd2fc"` this yields `"preview-pr-181-e"` — capturing only the first character of the 8-char unique commit hash. Two preview builds of the same PR whose hashes share the same leading hex digit (e.g. `preview-pr-181-e38dd2fc` and `preview-pr-181-eabcdef0`) would collide on the same destDir, preventing them from coexisting i
Check warning on line 6 in scripts/build/deps/webkit.ts
claude / Claude Code Review
Stale comment: WEBKIT_VERSION is a preview tag, not a commit hash
The JSDoc comment at the top of `webkit.ts` says "WebKit commit" and `--webkit-version=<hash>`, but `WEBKIT_VERSION` is now `"preview-pr-181-e38dd2fc"` — a named preview tag, not a git commit SHA. The `<hash>` placeholder in the override hint is misleading since preview-style strings are equally valid.
Loading