Skip to content

Preserve string-literal names in re-exports

0f8671e
Select commit
Loading
Failed to load commit list.
Merged

Preserve string-literal names in re-export clauses #29245

Preserve string-literal names in re-exports
0f8671e
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 13, 2026 in 15m 36s

Code review found 2 potential issues

Found 5 candidates, confirmed 2. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/regression/issue/29242.test.ts:13-20 Tests spawn processes but missing test.concurrent

Annotations

Check warning on line 20 in test/regression/issue/29242.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Tests spawn processes but missing test.concurrent

The four process-spawning tests run sequentially, which violates the test/CLAUDE.md guideline to prefer concurrent tests when multiple tests in the same file spawn processes or write files. Each test already uses a uniquely-named temp directory, so switching to test.concurrent is safe and straightforward.