Skip to content

cpu-prof: match Node/Deno Chrome DevTools format #29241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jarred-Sumner merged 17 commits into from
Apr 14, 2026
+378 −290

cpu-prof test: assert sum(positionTicks) <= hitCount in sourcemap pat…

36ee468
Select commit
Loading
Failed to load commit list.
Merged

cpu-prof: match Node/Deno Chrome DevTools format #29241

cpu-prof test: assert sum(positionTicks) <= hitCount in sourcemap pat…
36ee468
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 13, 2026 in 16m 32s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 0
🟣 Pre-existing 1
Severity File:Line Issue
🟣 Pre-existing src/bun.js/bindings/BunCPUProfiler.cpp:375-399 stopCPUProfilerAndGetJSON is dead code: PR changes have no runtime effect

Annotations

Check notice on line 399 in src/bun.js/bindings/BunCPUProfiler.cpp

See this annotation in the file changed.

@claude claude / Claude Code Review

stopCPUProfilerAndGetJSON is dead code: PR changes have no runtime effect 

This is a pre-existing issue: stopCPUProfilerAndGetJSON (BunCPUProfiler.cpp) has no callers anywhere in the codebase and is not declared in BunCPUProfiler.h — all production profiler stop paths go through Bun::stopCPUProfiler instead. The PR invested effort updating this dead function with the same positionTicks, functionDefLine/Column, and scratchURL isolation changes applied to the live implementation, but those changes have zero runtime effect. The dead function should be removed to avoid fut
View more details on Claude