child_process: honor runtime process.env.PATH in sync spawn variants #29239
+74
−2
Claude / Claude Code Review
completed
Apr 13, 2026 in 12m 36s
Code review found 1 potential issue
Found 2 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/regression/issue/29237.test.ts:44-51 |
stderr:ignore discards diagnostic output on test failure |
Annotations
Check warning on line 51 in test/regression/issue/29237.test.ts
claude / Claude Code Review
stderr:ignore discards diagnostic output on test failure
The test spawns its fixture subprocess with `stderr: "ignore"` (line 48), silently discarding all subprocess error output. When CodeRabbit suggested removing the flaky `expect(stderr).not.toContain("error:")` assertion, the correct fix was to keep `stderr: "pipe"` and drop only that assertion — not to discard stderr entirely. If the fixture ever fails in CI (e.g., chmod did not take effect, shebang problem, binary not found), the only failure information will be a mismatched stdout or exit-code
Loading