Skip to content

test: allow onTestFinished() and expect.assertions() in concurrent tests #29238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 11 commits into
base: main
Choose a base branch
from

address claude review nits

64eb666
Select commit
Loading
Failed to load commit list.
Open

test: allow onTestFinished() and expect.assertions() in concurrent tests #29238

address claude review nits
64eb666
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 13, 2026 in 34m 24s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/bun.js/test/bun_test.zig:422-425 pushCurrentCallback docstring contradicts field docstring re: expect.assertions

Annotations

Check warning on line 425 in src/bun.js/test/bun_test.zig

See this annotation in the file changed.

@claude claude / Claude Code Review

pushCurrentCallback docstring contradicts field docstring re: expect.assertions 

The `pushCurrentCallback` method docstring (lines 422-425 of bun_test.zig) still lists `expect.assertions` as a beneficiary of the callback stack, claiming it can "recover which sequence they belong to" — but the `current_callback_stack` field docstring in the same struct (lines 237-246) correctly says the opposite: these functions intentionally do not use this stack and throw unconditionally instead. Commit 64eb666 fixed the identical claim in Execution.zig but left the method docstring stale,
View more details on Claude