inspect: show real class name for DOM constructors, not [class Function]
#29229
+156
−7
Claude / Claude Code Review
completed
Apr 12, 2026 in 13m 45s
Code review found 2 potential issues
Found 5 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 2 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | test/regression/issue/29225.test.ts:40-55 |
Process-spawning tests not marked test.concurrent |
| 🟡 Nit | test/regression/issue/29225.test.ts:61-70 |
exitCode asserted before stdout in subprocess tests |
Annotations
Check warning on line 55 in test/regression/issue/29225.test.ts
claude / Claude Code Review
Process-spawning tests not marked test.concurrent
Three of the four new tests spawn independent Bun subprocesses but none are marked `test.concurrent`, violating `test/CLAUDE.md`'s guideline to use `test.concurrent` or `describe.concurrent` when multiple tests in the same file spawn processes. Since the three process-spawning tests are fully independent (no shared state), making them concurrent would be straightforward and would reduce CI time.
Check warning on line 70 in test/regression/issue/29225.test.ts
claude / Claude Code Review
exitCode asserted before stdout in subprocess tests
All three subprocess-spawning tests check `expect(exitCode).toBe(0)` before asserting stdout content, violating the CLAUDE.md mandate that stdout should be checked first. This means if a test fails due to wrong output, the error will report an exit code mismatch rather than showing the actual vs expected stdout, making debugging harder.
Loading