Skip to content

chore: Harden CI supply chain #29226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erezrokah wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −11
Open

chore: Harden CI supply chain #29226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/bump/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ runs:
echo "version=$LATEST" >> $GITHUB_OUTPUT
echo "message=$MESSAGE" >> $GITHUB_OUTPUT
- name: Create Pull Request
uses: peter-evans/create-pull-request@v7
uses: peter-evans/create-pull-request@22a9089034f40e5a961c8808d113e2c98fb63676 # v7
with:
add-paths: |
LATEST
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/format.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
bun-version: ${{ env.BUN_VERSION }}
- name: Setup Dependencies
run: |
bun install
bun ci
- name: Format Code
run: |
# Start prettier in background with prefixed output
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/packages-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ jobs:

- name: Install dependencies
run: |
bun install
pushd ./packages/bun-plugin-svelte && bun install
bun ci
pushd ./packages/bun-plugin-svelte && bun ci

- name: Lint
run: |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
with:
bun-version: "1.2.3"
- name: Install Dependencies
run: bun install
run: bun ci
- name: Sign Release
Comment on lines 72 to 76
Copy link

Copilot AI Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release.yml still references peter-evans/create-pull-request by mutable tag (@v7) later in the workflow (e.g., the DefinitelyTyped PR step). Since this PR is hardening CI supply chain, consider SHA-pinning that remaining usage as well (and keeping the # v7 comment) so the workflow is consistently protected against tag-rewrite compromises.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@erezrokah erezrokah Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't want to step on #28616 toes (see description)

run: |
echo "$GPG_PASSPHRASE" | bun upload-assets -- "${{ env.BUN_VERSION }}"
Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:
with:
bun-version: "1.2.3"
- name: Install Dependencies
run: bun install
run: bun ci
- name: Release
run: bun upload-npm -- "${{ env.BUN_VERSION }}" publish
env:
Expand Down Expand Up @@ -134,7 +134,7 @@ jobs:
with:
bun-version: "canary" # Must be 'canary' so tag is correct
- name: Install Dependencies
run: bun install
run: bun ci
- name: Setup Tag
if: ${{ env.BUN_VERSION == 'canary' }}
run: |
Expand Down Expand Up @@ -317,7 +317,7 @@ jobs:
with:
bun-version: "1.2.0"
- name: Install Dependencies
run: bun install
run: bun ci
- name: Release
run: bun upload-s3 -- "${{ env.BUN_VERSION }}"
env:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/vscode-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,18 @@ jobs:
bun-version: "1.2.18"

- name: Install dependencies (root)
run: bun install
run: bun ci

- name: Install dependencies
run: bun install
run: bun ci
working-directory: packages/bun-vscode

- name: Set Version
run: bun pm version ${{ github.event.inputs.version }} --no-git-tag-version --allow-same-version
working-directory: packages/bun-vscode

- name: Build (inspector protocol)
run: bun install && bun run build
run: bun ci && bun run build
working-directory: packages/bun-inspector-protocol

- name: Build (vscode extension)
Expand Down
Loading