Skip to content

Fix dynamic import() resolving before TLA module finishes evaluating #29224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 11 commits into
base: main
Choose a base branch
from
+204 −0

[autofix.ci] apply automated fixes

5b90abf
Select commit
Loading
Failed to load commit list.
Open

Fix dynamic import() resolving before TLA module finishes evaluating #29224

[autofix.ci] apply automated fixes
5b90abf
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 12, 2026 in 23m 0s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit test/regression/issue/29221.test.ts:21 Tests not marked test.concurrent despite both spawning processes

Annotations

Check warning on line 21 in test/regression/issue/29221.test.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Tests not marked test.concurrent despite both spawning processes 

Both tests use plain `test()` instead of `test.concurrent()`, violating the test/CLAUDE.md guideline that requires concurrent tests when multiple tests in the same file spawn processes. The fix is trivial: change both `test(` calls to `test.concurrent(`.
View more details on Claude