Skip to content

Stop dispatching parent messages to self.onmessage in node:worker_threads workers #29215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robobun wants to merge 12 commits into
base: main
Choose a base branch
from

worker_threads: preserve ports, support EventListenerObject, fix Abor…

6cc8135
Select commit
Loading
Failed to load commit list.
Open

Stop dispatching parent messages to self.onmessage in node:worker_threads workers #29215

worker_threads: preserve ports, support EventListenerObject, fix Abor…
6cc8135
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 12, 2026 in 10m 52s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit src/js/node/worker_threads.ts:188 Array.from used instead of $Array.from in makeForwarder

Annotations

Check warning on line 188 in src/js/node/worker_threads.ts

See this annotation in the file changed.

@claude claude / Claude Code Review

Array.from used instead of $Array.from in makeForwarder 

The makeForwarder closure uses Array.from(nativePorts) (line 188) instead of the tamper-resistant intrinsic $Array.from(nativePorts) mandated by src/js/CLAUDE.md. Since makeForwarder executes on every incoming parent message after user code may have already run, a user who replaces Array.from on globalThis could interfere with port delivery. Fix: replace Array.from(nativePorts) with $Array.from(nativePorts).
View more details on Claude