Skip to content

aboot: Add missing stdint.h include #3541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vadorovsky wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −0
Open

aboot: Add missing stdint.h include #3541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f48233d
aboot: Add missing `stdint.h` include
vadorovsky Oct 23, 2025
8dec9d7
ci: Add musl build job
vadorovsky Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,26 @@ jobs:
with:
name: inst.tar.zst
path: inst.tar.zst
build-musl:
name: "Build (Alpine)"
runs-on: ubuntu-latest
container: docker.io/alpine:latest
steps:
- name: Checkout repository
uses: actions/checkout@v3
- name: Install dependencies
run: |
apk update
apk add autoconf automake bison build-base curl-dev e2fsprogs-dev \
fuse-dev git glib-dev gpgme-dev libsoup-dev libtool pkgconfig xz-dev
# https://github.com/actions/checkout/issues/760
- name: Mark git checkout as safe
run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
- name: Build
run: |
env NOCONFIGURE=1 ./autogen.sh &&
./configure --with-curl --with-selinux --with-dracut=yesbutnoconf --without-selinux &&
make -j 4 && make install DESTDIR=$(pwd)/install && tar -c -C install --zstd -f inst.tar.zst .
privtest:
name: "Privileged testing"
needs: [build-c, build-integration]
Expand Down
1 change: 1 addition & 0 deletions src/libostree/ostree-bootloader-aboot.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "otutil.h"
#include <sys/mount.h>

#include <stdint.h>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This include is correct. For better code consistency, consider grouping all system headers and sorting them alphabetically. This would also remove the blank line that separates system includes. For example:

#include <stdint.h>
#include <string.h>
#include <sys/mount.h>

Copy link
Copy Markdown
Author

@vadorovsky vadorovsky Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disagree, I think that would add noise to the diff.

#include <string.h>

/* This is specific to aboot and zipl today, but in the future we could also
Expand Down
Loading