Skip to content

staged-deploy: Verify we didn't fail to unmount /sysroot or /etc #3520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cgwalters wants to merge 1 commit into
base: main
Choose a base branch
from
Open

staged-deploy: Verify we didn't fail to unmount /sysroot or /etc #3520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/kolainst/destructive/soft-reboot.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ case "${AUTOPKGTEST_REBOOT_MARK:-}" in
# Verify that soft-reboot state files are gone
test '!' -f /run/ostree/nextroot-booted

# And verify there were no failures to unmount /etc or /sysroot
journalctl -b -1 -u sysroot.mount -u etc.mount >previous-journal.txt
Copy link
Copy Markdown
Collaborator

@champtar champtar Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you do a soft reboot, for the journal it's still the same boot, ie you must use -b0 here

Copy link
Copy Markdown
Collaborator

@champtar champtar Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it more, the journal is pretty small, we can just remove the -b

assert_not_file_has_content previous-journal.txt Failed
rm -f previous-journal.txt

echo "Soft reboot test completed successfully!"

# Now soft reboot again into the rollback which is not staged,
Expand Down
Loading