Skip to content

UnTar: skip the '.' archive root entry#91

Closed
mzihlmann wants to merge 1 commit into
mainfrom
permissions
Closed

UnTar: skip the '.' archive root entry#91
mzihlmann wants to merge 1 commit into
mainfrom
permissions

Conversation

@mzihlmann

@mzihlmann mzihlmann commented Jun 30, 2025

Copy link
Copy Markdown
Collaborator

When untarring an archive whose root is . (for example a build context tar), UnTar passed the . entry to ExtractFile, which resolves to the destination directory itself and reapplies the entry's mode and ownership onto it. Skipping the . entry leaves the destination directory untouched.

@mzihlmann mzihlmann force-pushed the permissions branch 5 times, most recently from adfd360 to f1971be Compare July 5, 2025 22:19
@mzihlmann mzihlmann force-pushed the permissions branch 3 times, most recently from 50265bf to 9c14ac3 Compare July 26, 2025 07:14
@mzihlmann mzihlmann force-pushed the permissions branch 2 times, most recently from a64b36f to 4c2fe88 Compare August 24, 2025 08:28
@mzihlmann mzihlmann changed the title file permissions RUN: respect explicit group from USER Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@mzihlmann mzihlmann changed the title RUN: respect explicit group from USER UnTar: skip the '.' archive root entry Jun 26, 2026
@mzihlmann

Copy link
Copy Markdown
Collaborator Author

Reduced this to just the UnTar root-entry skip. The USER/RUN group handling moved to #840, where it is gated behind a feature flag.

@mzihlmann

Copy link
Copy Markdown
Collaborator Author

Superseded by #842, which fixes this behind the FF_KANIKO_UNTAR_SKIP_ROOT feature flag with an integration test, tracked in #841.

@mzihlmann mzihlmann closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant