unpin FF_KANIKO_NO_PROPAGATE_ANNOTATIONS in golden and rotate cache keys#874
Open
mzihlmann wants to merge 1 commit into
Open
unpin FF_KANIKO_NO_PROPAGATE_ANNOTATIONS in golden and rotate cache keys#874mzihlmann wants to merge 1 commit into
mzihlmann wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The golden suite has pinned FF_KANIKO_NO_PROPAGATE_ANNOTATIONS=0 since the v1.28.0 graduation to keep the cache keys in the plans stable. The stage elimination work on mz334 rotates all golden cache keys anyway, so this is a good moment to drop the pin and let the suite run with the flag at its production default. All plans were regenerated and the CachedKeys inputs re-derived. With the key values masked, every plan is byte identical to main, so no scenario's hit or miss structure changed.