v1.29.0 dry-run: flip switch-on feature flags to default#870
Draft
mzihlmann wants to merge 3 commits into
Draft
Conversation
… RUN_VIA_TINI, blocked on RISC-V tini)
…RESTORE with their documented default
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not merge. Dry-run to surface v1.29.0 regressions in CI ahead of the release, since last time issues only showed up just before cutting the release.
Flips the six switch-on feature flags scheduled to become default in v1.29.0 to default true at their read sites, keeping the flags readable so legacy-path tests still toggle: FF_KANIKO_SKIP_WRITE_WHITEOUTS, FF_KANIKO_INFER_CROSS_STAGE_CACHE_KEY, FF_KANIKO_REPRODUCIBLE_PRESERVE_BASE_LAYERS, FF_KANIKO_RESOLVE_CACHE_KEY, FF_KANIKO_SKIP_RELABEL_RECOMPRESS, FF_KANIKO_UNTAR_SKIP_ROOT.
FF_KANIKO_RUN_VIA_TINI stays default off because it is blocked on the tini binary shipping for RISC-V. The ten flags marked for deprecation in v1.29.0 already default to true, so their target behavior is exercised today and needs no change here. The --image-format=oci default flip lives in #850 and is not on main yet, so it is out of scope for this branch.