mz868: tolerate dangling symlink when resolving COPY destination#869
Draft
mzihlmann wants to merge 2 commits into
Draft
mz868: tolerate dangling symlink when resolving COPY destination#869mzihlmann wants to merge 2 commits into
mzihlmann wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #868
A COPY whose destination resolves through a dangling symlink aborted the build.
resolveIfSymlinkwalks the destination and callsfilepath.EvalSymlinkson the deepest existing component, which lstats the missing target of a dangling link and returns an error, surfaced asfailed to eval symlinks. docker writes through the link instead and builds fine. This drives the walk offEvalSymlinksdirectly and treats itsIsNotExistresult, whether the path is missing or points through a dangling symlink, as a component to be created rather than a hard error, so the destination resolves to the lexical path and the copy proceeds.