mz863: apply COPY --chmod to implicitly created parent directories#866
Open
mzihlmann wants to merge 2 commits into
Open
mz863: apply COPY --chmod to implicitly created parent directories#866mzihlmann wants to merge 2 commits into
mzihlmann wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #863
COPY --chmodapplied the mode to the copied file but left implicitly created parent directories at a fixed 0755, so kaniko and buildkit produced different directory permissions for the same Dockerfile.FF_KANIKO_COPY_CHMOD_ON_IMPLICIT_DIRSwas meant to cover this but only wired into the directory copy path, never the single file copy that creates parents throughcreateParentDirectory. This threads the implicit-dir permission throughCreateFileandcreateParentDirectoryso the flag applies on that path too, matching buildkit including the umask handling.