stop ignoring layer-length mismatch in integration tests#847
Open
mzihlmann wants to merge 7 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop passing
--extra-ignore-layer-length-mismatchto diffoci globally and enforce layer-length parity by default, so divergences are caught instead of hidden.Minimal bases (busybox/alpine/scratch) lack
/procand/sys, which BuildKit commits on the first RUN but kaniko ignores as mounts, so those tests now build from a prepared${IMAGE_REPO}busybox/alpinebase that bakes the dirs in.Genuine kaniko divergences from BuildKit (no COPY dedup, ignorelisted tar paths, ONBUILD base re-emission, empty package-manager dirs) keep an explicit per-test exception, to be fixed separately.
The four tests pinning old schema2 busybox digests moved onto the OCI prepared base, which flipped kaniko's output to OCI (it inherits the base media type), so their now-stale
--provenance=falseis dropped to keep both sides OCI.