mz843: generate integration tar fixtures on the fly#844
Open
mzihlmann wants to merge 1 commit into
Open
Conversation
mzihlmann
force-pushed
the
mz843-tars-on-the-fly
branch
from
caaf31d to
641abe1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #843
The integration suite committed opaque binary tar archives as test data (
file.tar,file.tar.gz,file.bz2,sys.tar.gz). A committed archive never shows up in a diff and can carry content the neighboring Dockerfile never describes, which is how the XZ Utils backdoor (CVE-2024-3094) hid its payload. These also buried the behavior under test, such as the mode of an archive root entry, behind bytes nobody reviews.The fixtures are now generated during test setup from an explicit spec (path, type, mode, content) with a pinned mtime, so the repository holds no committed archives and the generated path is git-ignored. The extracted trees are structurally identical to the old blobs (same names, modes, types, sizes) and
Dockerfile_test_addpasses against them. The unusedintegration/tar.tarimage export can be removed separately.