Skip to content

linter: ineffassign #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mzihlmann wants to merge 1 commit into from
Closed

linter: ineffassign #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/commands/copy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type CopyCommand struct {

func (c *CopyCommand) ExecuteCommand(config *v1.Config, buildArgs *dockerfile.BuildArgs) error {
// Resolve from
uid, gid := int64(-1), int64(-1)
var uid, gid int64
var err error
replacementEnvs := buildArgs.ReplacementEnvs(config.Env)
if c.cmd.From != "" {
Expand Down
1 change: 0 additions & 1 deletion pkg/commands/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ func runCommandWithFlags(config *v1.Config, buildArgs *dockerfile.BuildArgs, cmd
return fmt.Errorf("environment variable for secret %q not set: %s", secretId, s.Src)
}
secretData = []byte(val)
val = ""
} else {
secretData, err = os.ReadFile(s.Src)
if err != nil {
Expand Down
Loading