mz824: fold heredoc bodies into RUN cache key#825
Open
mzihlmann wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
mzihlmann
force-pushed
the
mz824-run-heredoc-cache-key
branch
from
dc784ab to
5c729fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #824
Stacked on #791, the only new commit is the last one (the first is a cherry-pick of #791 and should land first).
A RUN heredoc body is not part of the layer cache key. The key is keyed on the instruction text, which for a heredoc is just the
RUN <<EOFline, while the body lives incmd.Files. Two RUN steps that differ only in their body shared a key, so a build that changed only the script reused the stale layer. The raw heredoc bodies are now folded into the RUN cache key underFF_KANIKO_RESOLVE_CACHE_KEY, the same flag #791 introduced. The bodies are added verbatim rather than variable-resolved: the shell expands them at runtime and RUN already folds all env into its key, so the variable case was already covered and only the literal body text was missing.